WinterGram/submodules/LiveLocationManager/Sources/LiveLocationSummaryManager.swift
Isaac b2ba4b5878 Postbox -> TelegramEngine wave 7: last TelegramEngine.* facade leaks
Closes the seven remaining raw-Postbox leaks in TelegramEngine public
facades surfaced by a post-wave-6 scouting pass (all non-permanently-
blocked candidates).

Facades migrated in place (6 rewrites + 1 deletion; all _internal_*
implementations unchanged per the "internal Postbox-facing stays raw"
rule):

  Messages:
    downloadMessage                          Signal<Message?>           -> Signal<EngineMessage?>
    topPeerActiveLiveLocationMessages        Signal<(Peer?, [Message])> -> Signal<(EnginePeer?, [EngineMessage])>
    getSynchronizeAutosaveItemOperations     deleted (dead facade; sole caller uses _internal_ directly)

  Peers:
    updatedRemotePeer                        Signal<Peer>  -> Signal<EnginePeer>
                                             (PeerReference param kept; no EnginePeer.Reference alias today)

  Resources:
    renderStorageUsageStatsMessages          [EngineMessage.Id: Message]  -> [EngineMessage.Id: EngineMessage]
    clearStorage(peerId: ...)                [Message]                     -> [EngineMessage]
    clearStorage(peerIds: ...)               [Message]                     -> [EngineMessage]
    clearStorage(messages:)                  [Message]                     -> [EngineMessage]
                                             (no external callers; migrated for overload-set consistency)

Consumer call-site updates (5 files):
  - ChatListSearchListPaneNode       drop redundant .flatMap(EngineMessage.init) wrap
  - LocationViewControllerNode       drop redundant .map(EngineMessage.init) wrap
  - LiveLocationSummaryManager       drop redundant EnginePeer(...) / EngineMessage(...) ctors
  - StorageUsageScreen               bridge [Message] <-> [EngineMessage] at the 4 facade-call points
                                     (internal [MessageId: Message] / [Message] storage kept;
                                      full-consumer-module migration is out of scope)

Discovery: grep of TelegramEngine/*/TelegramEngine*.swift public signatures
for `: Postbox|: Account|: MediaBox|: MediaResource|: Peer\b|: Message\b|
-> Signal<.*(Peer|Message)` turned up these seven candidates and no others.
After this wave, the full TelegramEngine.* facade surface is engine-typed
modulo the four permanently-blocked TelegramMediaResource-conforming
classes recorded in CLAUDE.md (ICloudFileResource, InstantPageExternal-
MediaResource, VideoLibraryMediaResource, YoutubeEmbedStoryboardMedia-
Resource).

No modules became Postbox-free in this wave. Plan: docs/superpowers/
plans/2026-04-20-postbox-to-telegramengine-wave-7.md.

Full project build verified green.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-20 00:25:28 +02:00

259 lines
9.1 KiB
Swift

import Foundation
import TelegramCore
import SwiftSignalKit
import AccountContext
private final class LiveLocationSummaryContext {
private let queue: Queue
private let engine: TelegramEngine
private var subscribers = Bag<([EngineMessage.Id: EngineMessage]) -> Void>()
var messageIds = Set<EngineMessage.Id>() {
didSet {
assert(self.queue.isCurrent())
if self.messageIds != oldValue {
if self.messageIds.isEmpty {
self.disposable.set(nil)
self.messages = [:]
} else {
self.disposable.set((self.engine.data.subscribe(
TelegramEngine.EngineData.Item.Messages.Messages(ids: self.messageIds)
)
|> deliverOn(self.queue)).start(next: { [weak self] messages in
if let strongSelf = self {
strongSelf.messages = messages
}
}))
}
}
}
}
private var messages: [EngineMessage.Id: EngineMessage] = [:] {
didSet {
assert(self.queue.isCurrent())
for f in self.subscribers.copyItems() {
f(self.messages)
}
}
}
private let disposable = MetaDisposable()
init(queue: Queue, engine: TelegramEngine) {
self.queue = queue
self.engine = engine
}
deinit {
self.disposable.dispose()
}
func subscribe() -> Signal<[EngineMessage.Id: EngineMessage], NoError> {
let queue = self.queue
return Signal { [weak self] subscriber in
let disposable = MetaDisposable()
queue.async {
if let strongSelf = self {
let index = strongSelf.subscribers.add({ next in
subscriber.putNext(next)
})
subscriber.putNext(strongSelf.messages)
disposable.set(ActionDisposable { [weak self] in
queue.async {
if let strongSelf = self {
strongSelf.subscribers.remove(index)
}
}
})
}
}
return disposable
}
}
}
private final class LiveLocationPeerSummaryContext {
private let queue: Queue
private let engine: TelegramEngine
private let accountPeerId: EnginePeer.Id
private let peerId: EnginePeer.Id
private let becameEmpty: () -> Void
private var peersAndMessages: [(EnginePeer, EngineMessage)]? = nil {
didSet {
assert(self.queue.isCurrent())
for f in self.subscribers.copyItems() {
f(self.peersAndMessages)
}
}
}
private var _isActive: Bool = false
var isActive: Bool {
get {
return self._isActive
} set(value) {
if value != self._isActive {
let wasActive = self._isActive
self._isActive = value
if self._isActive != wasActive {
self.updateSubscription()
}
}
}
}
private var subscribers = Bag<([(EnginePeer, EngineMessage)]?) -> Void>()
var isEmpty: Bool {
return !self.isActive && self.subscribers.isEmpty
}
private let peerDisposable = MetaDisposable()
init(queue: Queue, engine: TelegramEngine, accountPeerId: EnginePeer.Id, peerId: EnginePeer.Id, becameEmpty: @escaping () -> Void) {
self.queue = queue
self.engine = engine
self.accountPeerId = accountPeerId
self.peerId = peerId
self.becameEmpty = becameEmpty
}
deinit {
self.peerDisposable.dispose()
}
func subscribe(_ f: @escaping ([(EnginePeer, EngineMessage)]?) -> Void) -> Disposable {
let wasEmpty = self.subscribers.isEmpty
let index = self.subscribers.add({ next in
f(next)
})
f(self.peersAndMessages)
if self.subscribers.isEmpty != wasEmpty {
self.updateSubscription()
}
let queue = self.queue
return ActionDisposable { [weak self] in
queue.async {
if let strongSelf = self {
let wasEmpty = strongSelf.subscribers.isEmpty
strongSelf.subscribers.remove(index)
if strongSelf.subscribers.isEmpty != wasEmpty {
strongSelf.updateSubscription()
}
if strongSelf.isEmpty {
strongSelf.becameEmpty()
}
}
}
}
}
private func updateSubscription() {
if self.isActive || !self.subscribers.isEmpty {
self.peerDisposable.set((self.engine.messages.topPeerActiveLiveLocationMessages(peerId: self.peerId)
|> deliverOn(self.queue)).start(next: { [weak self] accountPeer, messages in
if let strongSelf = self {
var peersAndMessages: [(EnginePeer, EngineMessage)] = []
for message in messages {
if let author = message.author {
if author.id != strongSelf.accountPeerId && message.flags.contains(.Incoming) {
peersAndMessages.append((author, message))
}
}
}
if peersAndMessages.isEmpty {
strongSelf.peersAndMessages = nil
} else {
strongSelf.peersAndMessages = peersAndMessages
}
}
}))
} else {
self.peerDisposable.set(nil)
self.peersAndMessages = nil
}
}
}
public final class LiveLocationSummaryManagerImpl: LiveLocationSummaryManager {
private let queue: Queue
private let engine: TelegramEngine
private let accountPeerId: EnginePeer.Id
private let globalContext: LiveLocationSummaryContext
private var peerContexts: [EnginePeer.Id: LiveLocationPeerSummaryContext] = [:]
init(queue: Queue, engine: TelegramEngine, accountPeerId: EnginePeer.Id) {
assert(queue.isCurrent())
self.queue = queue
self.engine = engine
self.accountPeerId = accountPeerId
self.globalContext = LiveLocationSummaryContext(queue: queue, engine: engine)
}
func update(messageIds: Set<EngineMessage.Id>) {
var peerIds = Set<EnginePeer.Id>()
for id in messageIds {
peerIds.insert(id.peerId)
}
for peerId in peerIds {
if self.peerContexts[peerId] == nil {
let context = LiveLocationPeerSummaryContext(queue: self.queue, engine: self.engine, accountPeerId: self.accountPeerId, peerId: peerId, becameEmpty: { [weak self] in
if let strongSelf = self, let context = strongSelf.peerContexts[peerId], context.isEmpty {
strongSelf.peerContexts.removeValue(forKey: peerId)
}
})
self.peerContexts[peerId] = context
}
}
for (peerId, context) in self.peerContexts {
context.isActive = peerIds.contains(peerId)
}
self.globalContext.messageIds = messageIds
}
public func broadcastingToMessages() -> Signal<[EngineMessage.Id: EngineMessage], NoError> {
return self.globalContext.subscribe()
}
public func peersBroadcastingTo(peerId: EnginePeer.Id) -> Signal<[(EnginePeer, EngineMessage)]?, NoError> {
let queue = self.queue
return Signal { [weak self] subscriber in
let disposable = MetaDisposable()
queue.async {
if let strongSelf = self {
let context: LiveLocationPeerSummaryContext
if let current = strongSelf.peerContexts[peerId] {
context = current
} else {
context = LiveLocationPeerSummaryContext(queue: strongSelf.queue, engine: strongSelf.engine, accountPeerId: strongSelf.accountPeerId, peerId: peerId, becameEmpty: {
if let strongSelf = self, let context = strongSelf.peerContexts[peerId], context.isEmpty {
strongSelf.peerContexts.removeValue(forKey: peerId)
}
})
strongSelf.peerContexts[peerId] = context
}
disposable.set(context.subscribe({ next in
subscriber.putNext(next)
}))
}
}
return disposable
}
}
}