fix(animation-cache): stop double-freeing DecompressedData.stream on failed init

compression_stream_init() failure was manually deallocating self.stream
before returning nil. Since all stored properties are already assigned
by that point, Swift still calls deinit on the failed-init instance,
which unconditionally destroys+deallocates self.stream again — a
double free that libsystem_malloc catches as "pointer being freed was
not allocated" (SIGABRT, DCTMultiAnimationRenderer-FirstFrame queue,
build 33197). Let deinit be the sole owner of that cleanup.
This commit is contained in:
ankuper 2026-07-03 03:25:17 -04:00
parent 6e370e06d1
commit 33e25d757d

View file

@ -971,8 +971,16 @@ private final class DecompressedData {
self.dataRange = dataRange
self.stream = UnsafeMutablePointer<compression_stream>.allocate(capacity: 1)
// Do NOT deallocate self.stream here on failure: since all stored
// properties (incl. self.stream) are already assigned at this point,
// Swift's ARC still calls deinit on this failed-init instance once
// `return nil` executes below and deinit unconditionally destroys
// and deallocates self.stream too. Deallocating it here as well was a
// double free (libsystem_malloc "pointer being freed was not
// allocated" -> SIGABRT, seen in the field on rare
// compression_stream_init failures). Let deinit be the single owner
// of that cleanup.
guard compression_stream_init(self.stream, COMPRESSION_STREAM_DECODE, algorithm) != COMPRESSION_STATUS_ERROR else {
self.stream.deallocate()
return nil
}