github-mirror/Telegram-iOS
1
0
Fork 0
mirror of https://github.com/TelegramMessenger/Telegram-iOS.git synced 2026-07-06 03:33:41 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(chat): disable ExperimentalInternalTranslationServiceImpl (SwiftUI trap)

Browse source 
ExperimentalInternalTranslationServiceImpl.init constructs a
UIHostingController(rootView: TranslationViewImpl(...)) that fatal-traps
inside SwiftUI/Translation-framework internals on device (SIGABRT, no
application-code frames at the trap site — confirmed on iOS 26.5,
reproducible on the first chat opened per app session, matching the
report of the app crashing quickly when viewing chats).

Confirmed against upstream: teleproto3-support's merge-base with
TelegramMessenger/Telegram-iOS master IS upstream's current tip, so this
is not something already fixed there — it needs a local mitigation.

A trap inside Apple's own framework code cannot be guarded or caught
from Swift, so the only available fix is not calling into it. Disabling
this local/on-device translation path is safe: TelegramCore's translate()
already falls back to server-side translation whenever
engineExperimentalInternalTranslationService is nil (Translate.swift:228),
which is now unconditionally the case.
This commit is contained in:
ankuper 2026-07-02 14:20:04 -04:00
parent 6e370e06d1
commit 1e3eb721aa
1 changed files with 16 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

22
submodules/TelegramUI/Sources/Chat/ChatControllerLoadDisplayNode.swift
View file

@ -683,12 +683,22 @@ extension ChatControllerImpl {
}
}
if #available(iOS 18.0, *) {
if engineExperimentalInternalTranslationService == nil, let hostView = self.context.sharedContext.mainWindow?.hostView {
let translationService = ExperimentalInternalTranslationServiceImpl(view: hostView.containerView)
engineExperimentalInternalTranslationService = translationService
}
}
// Disabled: ExperimentalInternalTranslationServiceImpl.init constructs a
// UIHostingController(rootView: TranslationViewImpl(...)) that fatal-traps
// inside SwiftUI/Translation-framework internals on device (SIGABRT, no
// application-code frames at the trap site — confirmed on iOS 26.5,
// reproducible on the first chat opened per app session). A trap inside
// Apple's own framework code cannot be guarded or caught from Swift, so
// the only available mitigation is not calling into it. Re-enable once
// the underlying SwiftUI + .translationTask interop bug is understood
// or fixed by an OS update.
//
// if #available(iOS 18.0, *) {
// if engineExperimentalInternalTranslationService == nil, let hostView = self.context.sharedContext.mainWindow?.hostView {
// let translationService = ExperimentalInternalTranslationServiceImpl(view: hostView.containerView)
// engineExperimentalInternalTranslationService = translationService
// }
// }
self.displayNode = ChatControllerNode(context: self.context, chatLocation: self.chatLocation, chatLocationContextHolder: self.chatLocationContextHolder, subject: self.subject, controllerInteraction: self.controllerInteraction!, chatPresentationInterfaceState: self.presentationInterfaceState, automaticMediaDownloadSettings: self.automaticMediaDownloadSettings, navigationBar: self.navigationBar, statusBar: self.statusBar, backgroundNode: self.chatBackgroundNode, controller: self)